Decorators may get applied multiple times

[shilman]

Issue by mnmtanish
Tuesday Jul 26, 2016 at 07:27 GMT
Originally opened as storybook-eol/react-native-storybook#50

---

Check whether this issue reported on react-storybook repo exists here. It is more likely that it does. Unfortunately we can't apply the solution used there because react-native HMR does not support dispose handlers. Investigate this issue and find a good solution.

If the issue exists, I think users can prevent it by manually calling clearDecorators from the config.js file. Global decorators are not that common so this issue is not critical. We can do it after optimising ios/android setup guides.

[shilman]

Comment by mnmtanish
Tuesday Nov 08, 2016 at 11:06 GMT

---

TODO:

• try to reproduce this issue and check whether it exists
• find a solution without adding extra config for users

[ndelangen]

I'd expect this issue to have gotten some +1s if what's described here truly happens.

If you are experience this issue, please re-open!

[macrozone]

@ndelangen yes, this happens.

It happens when your decorator is a class. You need to have a class when you use styled-components and want the theme to be hot-reloadable see comment below

[macrozone]

Any update or workarounds for this?

Edit: What i said above is not true, it also happens if your decorator is a stateless component

[ndelangen]

changes made to react version:
https://github.com/storybooks/storybook/pull/335/files

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

[stale]

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!