This repository has been archived by the owner on Jan 16, 2023. It is now read-only.
Fixed container array issue in header.js #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisTB
approved these changes
Oct 11, 2018
|
This PR needs to be merged. Current Chrome version released yesterday, 24/4/2019 (Version 74.0.3729.108 (Official Build) (32-bit)) makes the component fail completely. |
|
done. Anyway I upgrade the current chrome version to v74 and react-treebeard on v3.2.0 working correctly. What's the error? @simmerkaer |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox was raising a TypeError when react attempted to apply an array of styles taken from the container value into a header. The fix simply made it a merged single object as opposed to an array of 2 objects, one being null if not active.