Core: Fix process is not defined

[joshwooding]

Issue: #18366

What I did

Moved memoizerific to dependencies.

memoizerific has package.json#browser

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4d72da1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[joshwooding]

Not sure if global should be moved to dependencies in the packages too?

[shilman]

@joshwooding we are prebundling dev dependencies in @storybook/router, so this might not do what you think it does. hopefully @ndelangen can clarify here.

[joshwooding]

@joshwooding we are prebundling dev dependencies in @storybook/router, so this might not do what you think it does. hopefully @ndelangen can clarify here.

Yeah, moving the dependencies to "dependencies" prevents prebundling from what I could tell. Memoizerific isn't suitable for prebundling since it has a browser implementation of it's code and qs was previously moved elsewhere but not sure if those changes are needed elsewhere... looking forward to the clarification :)

[shilman]

This looks like it was addressed a different way in #18412

@Andarist if you see this can you please take a look at @joshwooding 's comment above? Many thanks! 🙏

[Andarist]

Yep, some dependencies are just not suitable for prebundling - qs is definitely one of them and if memoizerific has browser field then it isn't either. In general, I think that prebundling should only happen to specific libraries - when it solves a problem for you, but by default, it shouldn't be applied and things should be left in dependencies. My motivation is to avoid exactly such problems like this one and to avoid duplicating code as what gets prebundled can't be deduplicated by a package manager. Of course, YMMV

This looks like it was addressed a different way in #18412

I think I'm applying a similar fix there (moving a package from devDep to dep, but I've only moved qs there), just for different reasons. I was solely investigating a PnP-incompatibility reported by the user and this PR here focuses on fixing packages that were prebundled using a wrong env target (prebundled for node when the final env of a consumer is a browser). Both problems can usually be fixed in the same way.

[joshwooding]

I've updated this PR to only tackle memoizerific since qs was fixed in #18412

[Andarist]

LGTM - however, I don't think that I should be the one to merge this since I'm mostly an external contributor here 😉