-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview: Ensure docs container re-renders when globals change #18711
Preview: Ensure docs container re-renders when globals change #18711
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 47c51cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
The errors here seem to exist already on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests 💯
@tmeasday I noticed in QA that when you update the globals the story gets re-rendered twice. Is that intentional? the docs container gets re-rendered once as expected |
I think the story already got rendered twice, maybe due to strict mode? It might be something that's worth a little bit of investigation, I'll take a look. |
I checked and it does seem like |
…-to-global-values-do-not Preview: Ensure docs container re-renders when globals change
Issue: #18477 #18771
What I did
Added a story to demonstrate and ensure that
DocsRender
always re-renders on globals changeHow to test