Build: Use updated circleci node images #18785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
This updates the circleci node images to https://circleci.com/developer/images/image/cimg/node to replace the deprecated version that is locked on node 14.17, which does not support vite 3, causing the vite e2e tests to fail.
This change was attempted in #17832 previously, and reverted in 7ffc089, but my guess is that it was because the new images do not actually include any browsers, which should be solved by using the browser-tool orb, according to CircleCI-Public/cimg-node#186.
How to test
This should cause the vite react e2e test to start to pass.