Vue3: Add generic renderer stories & delete vue3 example #19219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
approved these changes
Sep 20, 2022
Comment on lines
+5
to
+8
| // TODO: I'd like to be able to export rather than imperatively calling an imported function | ||
| // export const setup = (app) => { | ||
| // app.component('GlobalButton', Button); | ||
| // }; |
There was a problem hiding this comment.
Is this a concept we want to add everywhere? Like a setup function in preview.js? Is there a use case where you wouldn't just immediately call it right away (in which case maybe having it would be adding complexity for its own sake)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
examples/vue-3-clito Vue3 rendererexamples/vue-3-cliHow to test