Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure v6 store works even with no explicit renderer #19624

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Ensure v6 store works even with no explicit renderer #19624

merged 2 commits into from
Oct 26, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 26, 2022 •
edited
Loading

Issue: Angular CLI (and likely Ember) didn't work in v6 mode.

What I did

As discussed, getRendererName falls back to getFrameworkName for now. Once we actually split those renderers we should probably revert this PR.

How to test

yarn task --task sandbox --no-link --template angular-cli/default-ts --start-from install
cd sandbox/angular-cli-default-ts
# update to v6 store
yarn storybook

@tmeasday tmeasday requested a review from shilman October 26, 2022 02:45
shilman
shilman approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

code/lib/core-common/src/utils/get-renderer-name.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday merged commit 82e91db into next Oct 26, 2022
@tmeasday tmeasday deleted the tom/sb-879-fix-v6-angularember-support branch October 26, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman