Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: use tsup for core-server #20134

Merged
merged 13 commits into from
Dec 24, 2022
Merged

Build: use tsup for core-server #20134

merged 13 commits into from
Dec 24, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 7, 2022

Issue: #18732

Thanks for @tmeasday I was able to get the star-shaped-puzzle pieces to align.

@ndelangen ndelangen self-assigned this Dec 7, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 7, 2022
@socket-security
Copy link

socket-security bot commented Dec 7, 2022

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@ndelangen ndelangen marked this pull request as draft December 7, 2022 16:59
@ndelangen ndelangen force-pushed the tech/tsup-core-server-v2 branch from 4143f84 to ff6b28e Compare December 7, 2022 18:19
@ndelangen ndelangen requested a review from IanVS December 7, 2022 18:40
@ndelangen ndelangen added the ci:merged Run the CI jobs that normally run when merged. label Dec 8, 2022
@ndelangen ndelangen marked this pull request as ready for review December 22, 2022 11:13
@ndelangen
Copy link
Member Author

@shilman we talked about this.. Let's do a release... then merge this, and do another release, OK?

I suspect it will be fine. It'd be great to have this merged, but I'll wait for you to do it ❤️

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!

@shilman shilman merged commit b8f74ce into next Dec 24, 2022
@shilman shilman deleted the tech/tsup-core-server-v2 branch December 24, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants