Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Scroll to highlighted search result #21692

Merged
merged 2 commits into from
Mar 28, 2023
Merged

UI: Scroll to highlighted search result #21692

merged 2 commits into from
Mar 28, 2023

Conversation

gitstart
Copy link
Contributor

Issue: #21323

What I did

  • Scroll the highlighted search result into view when using keyboard to navigate between search results

How to test

  • Start any storybook sandbox template.
  • Enter "e" in search input to have enough search results, using keyboard down to navigate between results to see the focused result is always in view.

This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

@gitstart gitstart marked this pull request as ready for review March 20, 2023 15:40
@ndelangen ndelangen added the bug label Mar 27, 2023
valentinpalkovic
valentinpalkovic approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@valentinpalkovic valentinpalkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much :)

@valentinpalkovic valentinpalkovic merged commit 7cc5e2e into storybookjs:next Mar 28, 2023
@shilman shilman mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitstart @valentinpalkovic @ndelangen