Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CosmWasm v2 go.mod package syntax should not break libwasmvm_muslc.a file download #253

Closed
pharr117 opened this issue Jun 12, 2024 · 0 comments · Fixed by #259
Closed

CosmWasm v2 go.mod package syntax should not break libwasmvm_muslc.a file download #253

pharr117 opened this issue Jun 12, 2024 · 0 comments · Fixed by #259
Assignees

Comments

@pharr117
Copy link
Contributor

We provide the wasm vm repo to the build dockerfiles by pulling the wasm version from the chain's go.mod file.

CosmWasm v2 package syntax contains the v2 (which is valid go packaging syntax), see the below link for latest Neutron as an example:

https://github.com/neutron-org/neutron/blob/329dcfed29fbef9a6b9db9920f430eb48b2d5cb1/go.mod#L17C2-L17C38

Heighliner parses thhis and reports the following:

WasmVM from go.mod: repo: github.com/CosmWasm/wasmvm/v2, version: v2.0.0

This is not a valid URL to the CosmWasm repo, the v2 needs to be removed. This leads to failure during dockerfile build like:

 ---> Running in f3e3ce4847a9
+ uname -m
+ export 'ARCH=x86_64'
+ '[' '!' -z 'github.com/CosmWasm/wasmvm/v2 v2.0.0' ]
+ echo github.com/CosmWasm/wasmvm/v2 v2.0.0
+ awk '{print $1}'
+ WASMVM_REPO=github.com/CosmWasm/wasmvm/v2
+ echo github.com/CosmWasm/wasmvm/v2 v2.0.0
+ awk '{print $2}'
+ WASMVM_VERS=v2.0.0
+ uname -m
+ wget -O /lib/libwasmvm_muslc.a https://github.com/CosmWasm/wasmvm/v2/releases/download/v2.0.0/libwasmvm_muslc.x86_64.a
Connecting to github.com (140.82.112.3:443)
wget: server returned error: HTTP/1.1 404 Not Found

We will need to build an alternate CosmWasm v2 URL parser here:

wasmvmRepo = item.Syntax.Token[0]
wasmvmVersion = item.Syntax.Token[1]

@jonathanpberger jonathanpberger changed the title CosmWasm v2 go.mod package syntax breaks libwasmvm_muslc.a file download CosmWasm v2 go.mod package syntax should not break libwasmvm_muslc.a file download Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants