Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Rust docs on protocols::v2::sv2-ffi #1015

Open
rrybarczyk opened this issue Jun 26, 2024 · 4 comments
Open

Need Rust docs on protocols::v2::sv2-ffi #1015

rrybarczyk opened this issue Jun 26, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation ffi FFI related logic protocols Lowest level protocol logic

Comments

@rrybarczyk
Copy link
Collaborator

rrybarczyk commented Jun 26, 2024

Background

Currently, the protocols::v2::sv2-ffi logic does not contain any in-line rust documentation, resulting in no documentation on its crates.io site.

Note: While this issue addresses the need for doc comments, it will also serve as a means to identify code debt that needs to be cleaned up and addressed in future issues.

Problem

When a user navigates to this crate crates.io, there is no useful information for the user. This impedes understanding and adoption.

Solution

Navigate through each crate in protocols::v2::sv2-ffi and add:

  • Rust Docs comments (following the formatting structure in this on-going discussion), to be displayed in docs.rs
  • a descriptive README.md file to be displayed in crates.io

While this work is being performed, specific code debt should be looked for and recorded to turn into future issues

@rrybarczyk rrybarczyk added documentation Improvements or additions to documentation ffi FFI related logic protocols Lowest level protocol logic labels Jun 26, 2024
@rrybarczyk rrybarczyk self-assigned this Sep 9, 2024
@Shourya742
Copy link
Contributor

@rrybarczyk May I take this on? I would like to explore FFI binding in Rust.

@rrybarczyk
Copy link
Collaborator Author

Added you as an assignee.

@Fi3
Copy link
Collaborator

Fi3 commented Oct 7, 2024

@GitGab19 GitGab19 added this to the 1.2.0 milestone Oct 11, 2024
@plebhash plebhash removed this from the 1.2.0 milestone Oct 11, 2024
@rrybarczyk
Copy link
Collaborator Author

We are going to deprioritize docs on sv2-ffi because this crate does not have complete functionality (see #919) and the other protocols/ crates should be prioritized as they are more critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ffi FFI related logic protocols Lowest level protocol logic
Projects
Status: Todo 📝
Development

No branches or pull requests

5 participants