Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing config naming across roles #1260

Open
jbesraa opened this issue Nov 19, 2024 · 2 comments
Open

Fixing config naming across roles #1260

jbesraa opened this issue Nov 19, 2024 · 2 comments

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Nov 19, 2024

Config object across different roles is not well named. For example JDC config is called ProxyConfig we should change it to JDCConfig and so on for all other roles [RoleName]Config.

@devworlds
Copy link

Basically, need to change the ProxyConfig Object to JDCConfig, and update all references that use it?
image

@Shourya742
Copy link
Contributor

Basically, need to change the ProxyConfig Object to JDCConfig, and update all references that use it? image

Yes and do the same for similar patterns you see in other roles crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants