Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tproxy from panicing if downstream address is unavailable #1279

Open
jbesraa opened this issue Dec 9, 2024 · 0 comments
Open

Prevent tproxy from panicing if downstream address is unavailable #1279

jbesraa opened this issue Dec 9, 2024 · 0 comments
Assignees
@Shourya742
Labels
bug Something isn't working refactor Implies refactoring code translation proxy SV1>SV2 translation proxy issues
Milestone
1.3.0

Comments

@jbesraa
Copy link
Contributor

jbesraa commented Dec 9, 2024

We should handle the unwrap here, otherwise tproxy panics although this peer address is only needed for logs

stratum/roles/translator/src/lib/downstream_sv1/downstream.rs

Line 385 in 407c642

let host = stream.peer_addr().unwrap().to_string();

original issue: #1273
@jbesraa jbesraa changed the title Prevent tproxy from panicing if downstream address is unavialable Prevent tproxy from panicing if downstream address is unavailable Dec 9, 2024
@pavlenex pavlenex added the translation proxy SV1>SV2 translation proxy issues label Dec 9, 2024
@plebhash plebhash added bug Something isn't working refactor Implies refactoring code labels Jan 21, 2025
@GitGab19 GitGab19 added this to the 1.3.0 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shourya742 Shourya742

Labels
bug Something isn't working refactor Implies refactoring code translation proxy SV1>SV2 translation proxy issues
Projects
SV2 Roadmap 🛣️
Status: Todo 📝
Milestone
1.3.0
Development

No branches or pull requests
5 participants
@jbesraa @pavlenex @GitGab19 @Shourya742 @plebhash