Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-test crate as a development tool for SRI ecosystem #1317

Closed
plebhash opened this issue Dec 22, 2024 · 4 comments · Fixed by #1340
Closed

integration-test crate as a development tool for SRI ecosystem #1317

plebhash opened this issue Dec 22, 2024 · 4 comments · Fixed by #1340

Comments

@plebhash
Copy link
Collaborator

plebhash commented Dec 22, 2024

imagine a future where the SRI-ecosystem uses Integration Testing for developing SRI-based apps

we would probably publish the ITF crate to crates.io

there's a few things that need to be addressed before this is possible:

  • currently, this crate is called integration-test, which is obvious if the reader is inside the SRI repo and already has full context... but for a wider audience, it would be better to give this crate a more meaningful name with some kind of reference to SRI or Sv2
  • the crate doesn't export any lib, which means the common module is not accessible, even if we add the crate as a dependency for another project
@jbesraa
Copy link
Contributor

jbesraa commented Dec 22, 2024

I am not entirely sure what do you mean by "imagine a future where the SRI-ecosystem uses Integration Testing for developing SRI-based apps"

@plebhash
Copy link
Collaborator Author

plebhash commented Dec 22, 2024

I am not entirely sure what do you mean by "imagine a future where the SRI-ecosystem uses Integration Testing for developing SRI-based apps"

SRI-based apps are not going to be restricted to what currently lives under roles

the community will develop their own opinionated applications, and leveraging the integration tests crate for that will be useful (should be published to crates.io etc)

the main point here is that the crate name should have some kind of reference to SRI or Sv2, so that whenever we publish this crate it's not living on crates.io with a generic and context-lacking name like integration-tests

@plebhash
Copy link
Collaborator Author

plebhash commented Dec 22, 2024

I'm simply taking note of this because I'm doing some experimentations of writing some application crates that use SRI as a dependency and I'm using ITF to drive development

as I added it to my Cargo.toml it occurred to me that this crate name has no reference to SRI or Sv2

we don't have to implement this change now, but this is just something that needs to be evaluated before we publish this crate to crates.io (whenever that day comes)

@plebhash
Copy link
Collaborator Author

just noticed that there's no lib, which means the crate (more specifically the common module) cannot be imported as a dependency

I'll rename the issue so it's more generic and not only about the crate name

@plebhash plebhash changed the title consider renaming integration-test crate integration-test crate as a development tool for SRI ecosystem Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants