New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant JD tests after JD spec update #1322

Open

jbesraa opened this issue Dec 24, 2024 · 1 comment

Contributor

jbesraa commented Dec 24, 2024

Once this PR stratum-mining/sv2-spec#104 is merged, we should remove the following tests as the support for async job is dropped in the new spec.

https://github.com/stratum-mining/stratum/tree/main/test/message-generator/test/jds-setupconnection-with-async-support

https://github.com/stratum-mining/stratum/tree/main/test/message-generator/test/jds-setupconnection-without-async-support

Collaborator

plebhash commented Jan 3, 2025

clarification: stratum-mining/sv2-spec#104 is a simple cleanup

the PR that will introduce breaking changes to the JD protocol spec will be done in a follow-up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment