-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-toolchain.toml #1333
Comments
This comment was marked as outdated.
This comment was marked as outdated.
yep I agree, but we removed it cause it was creating issues to some IDEs don't know which ones so before re adding it we should double check it. |
@Fi3 we were discussing this in a call earlier today one of the questions that came up was why we're using stratum/.github/workflows/fmt.yaml Line 30 in 7483090
@jbesraa mentioned that you had explained this a while ago over Discord but we couldn't find the messages |
last time that I looked into it was required by our rustfmt.toml that if I remember correctly have been added by @rrybarczyk so maybe she know better then me |
We have observed instances where pull requests include unexpected formatting changes and Clippy fixes that were not present initially. This issue occurs because contributors are using different Rust versions, leading to inconsistencies caused by differences in toolchain behavior. To resolve this, we should add a
rust-toolchain.toml
file to the repository to enforce a consistent Rust version across all contributors. This will ensure that formatting and linting remain uniform, preventing unrelated changes from appearing in pull requests.Few recent examples:
The text was updated successfully, but these errors were encountered: