Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-toolchain.toml #1333

Open
Shourya742 opened this issue Jan 7, 2025 · 4 comments · May be fixed by #1335
Open

Add rust-toolchain.toml #1333

Shourya742 opened this issue Jan 7, 2025 · 4 comments · May be fixed by #1335

Comments

@Shourya742
Copy link
Contributor

Shourya742 commented Jan 7, 2025

We have observed instances where pull requests include unexpected formatting changes and Clippy fixes that were not present initially. This issue occurs because contributors are using different Rust versions, leading to inconsistencies caused by differences in toolchain behavior. To resolve this, we should add a rust-toolchain.toml file to the repository to enforce a consistent Rust version across all contributors. This will ensure that formatting and linting remain uniform, preventing unrelated changes from appearing in pull requests.

Few recent examples:

  1. fix sigterm issue with translator sv2 #1319 (review)
@GitGab19

This comment was marked as outdated.

@Shourya742 Shourya742 linked a pull request Jan 8, 2025 that will close this issue
@Fi3
Copy link
Collaborator

Fi3 commented Jan 8, 2025

yep I agree, but we removed it cause it was creating issues to some IDEs don't know which ones so before re adding it we should double check it.

@plebhash
Copy link
Collaborator

plebhash commented Jan 8, 2025

@Fi3 we were discussing this in a call earlier today

one of the questions that came up was why we're using nightly on the fmt workflow:

toolchain: nightly

@jbesraa mentioned that you had explained this a while ago over Discord but we couldn't find the messages

@Fi3
Copy link
Collaborator

Fi3 commented Jan 9, 2025

last time that I looked into it was required by our rustfmt.toml that if I remember correctly have been added by @rrybarczyk so maybe she know better then me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants