Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider avoid running workflows AFTER merging PRs #1372

Closed
plebhash opened this issue Jan 21, 2025 · 0 comments · Fixed by #1373
Closed

consider avoid running workflows AFTER merging PRs #1372

plebhash opened this issue Jan 21, 2025 · 0 comments · Fixed by #1373
Labels
ci/cd CI/CD

Comments

@plebhash
Copy link
Collaborator

plebhash commented Jan 21, 2025

most of our CI workflows are set to that we run them before and after PRs are merged

on:
  push:
    branches:
      - main
  pull_request:
    branches:
      - main

I'm not sure about the motivation for running them after the PRs have already been merged... personally speaking, I never really check that, I only care about CI before the PRs are merged (as a safeguard against introducing bugs etc)

given that our repo can only run a limited number of workflows at the same time, this is actually introducing a significant bottleneck that severely slows down the process of merging PRs, especially when there's multiple PRs already approved and buffered for merging

unless I'm missing some important detail for the motivation for this, IMO we should stop running workflows after the PRs have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant