Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm and rmSync don't work on a patched-in memfs volume #320

Closed
thomasperi opened this issue Jan 24, 2022 · 3 comments
Closed

rm and rmSync don't work on a patched-in memfs volume #320

thomasperi opened this issue Jan 24, 2022 · 3 comments
Labels

Comments

@thomasperi
Copy link

thomasperi commented Jan 24, 2022

Deleting a directory with rm or rmSync does not delete the directory when run on a memfs Volume patched in with patchFs.

Both methods work when using a memfs Volume directly, just not with patchFs.

Only the rm and rmSync methods don't work. The rmdir and rmdirSync methods seem to work as intended with patchFs and an memfs Volume.

fs-monkey/src/util/lists.js doesn't contain rm or rmSync. I'm not sure whether they were left out intentionally for some reason, or if their absence really is a bug.

memfs-rm.js.txt

@G-Rath
Copy link
Collaborator

G-Rath commented Jul 12, 2022

Yup this sounds like a bug that should hopefully be fixed by #362, however CI is currently broken so we can't publish new releases until #366 is resolved by @streamich

@G-Rath G-Rath added the bug label Jul 12, 2022
@larshp
Copy link

larshp commented Sep 21, 2022

I have encountered the same problem

@G-Rath
Copy link
Collaborator

G-Rath commented Jun 2, 2023

This has been released in v1.0.4 🎉

@G-Rath G-Rath closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants