Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue of passing varargs and string to Sprintf. Closes #619 #620

Closed
wants to merge 2 commits into from

Conversation

devdinu
Copy link
Contributor

@devdinu devdinu commented Jun 22, 2018

Build fails with recent go version in mock package.

./mock.go:506: missing ... in args forwarded to printf-like function
./mock.go:523: missing ... in args forwarded to printf-like function

This fixes #619.

Copy link

@georgelesica-wf georgelesica-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I ran into this and while this seems like a strange fix, it works.

@devdinu
Copy link
Contributor Author

devdinu commented Sep 18, 2018

The tests were failing for all PRs before this fix, and recent PR's CI tests succeeds. So this must be specific to some tip version of go. We could drop this PR if its non mandated by go changes in release. We can retrigger the CI for the failed PR to verify.

@georgelesica-wf
Copy link

Good call, let's leave it open but put it on hold for now until we're sure we don't need it. Thanks.

Dinesh Kumar added 2 commits August 2, 2019 18:00
(cherry picked from commit 92c097a5af7b4bbbe3a66c2e7484f68194cd555a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are failing with go tip versions
2 participants