Fix a panic when comparing types where the underlying type is string #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was checking if the type's _kind_ was string and then attempting to do a type assertion of `var.(string)`. However, this assertion only works if the type actually _is_ a string. If it's some other type (like `type foo string`) then this ends up giving us a runtime panic.
|
Travis failure is because of #619 |
|
Ping |
|
I'm hitting this issue w/ 1.2.2. Any chance we can get this merged? I verified the change fixes it for me as well. |
jwilder
approved these changes
Jul 20, 2018
jwilder
added a commit
to jwilder/testify
that referenced
this pull request
Sep 14, 2018
|
@georgelesica-wf - the test in that other PR looks to be functionally the same as the one I added, so I'm sure it fixes the issue as best as I could test it. I don't have any other code that causes this issue to run the PR branch against. |
|
Cool, thanks! Would you have any objection if we merged the one I linked? I won't close this one until that's done, however. |
|
Yeah, I'm fine with anything that fixes this bug. |
|
Perhaps I'm little bit late to the party, tried to fix it too in #674 |
|
This was fixed a while back in a different commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was checking if the type's kind was string and then attempting to
do a type assertion of
var.(string). However, this assertion only works ifthe type actually is a string. If it's some other type (like
type foo string) then this ends up giving us a runtime panic.