Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include webhook events https://github.com/kgajera/stripe-event-types #1664

Closed
crobinson42 opened this issue Jan 26, 2023 · 4 comments
Closed

Comments

@crobinson42
Copy link

Is your feature request related to a problem? Please describe.

Webhook event TypeScript typings

Describe the solution you'd like

This should be included in this repo: https://github.com/kgajera/stripe-event-types

Describe alternatives you've considered

dying from manually assigning type annotations.

Additional context

No response

@anniel-stripe
Copy link
Contributor

Hi, thanks for the feature request! We likely won't get around to this immediately, but this is a great idea.

@zerefdev
Copy link

Hi, thanks for the feature request! We likely won't get around to this immediately, but this is a great idea.

Is there a reason not to get around this immediately/soon?
event.data.object typed as {} is annoying.

@anniel-stripe
Copy link
Contributor

anniel-stripe commented Feb 17, 2023

Is there a reason not to get around this immediately/soon?

We certainly want this feature and hope to get to it soon! However, we’d like to generate webhook event types to ensure completeness / accuracy for users, but the OpenAPI spec which our generator uses as input does not define webhook events yet. This needs to happen first before we can generate webhook event type definitions, and unfortunately it’s not a trivial change.

@pakrym-stripe
Copy link
Contributor

Closing as a duplicate of #902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants