From c53f19e545f9b596516f4a3364b6676330b47c63 Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Mon, 7 May 2018 15:41:04 -0700 Subject: [PATCH 1/6] Add support for v1/issuer_fraud_records endpoint typo --- lib/resources/IssuerFraudRecords.js | 15 +++++++++ test/resources/IssuerFraudRecords.spec.js | 39 +++++++++++++++++++++++ 2 files changed, 54 insertions(+) create mode 100644 lib/resources/IssuerFraudRecords.js create mode 100644 test/resources/IssuerFraudRecords.spec.js diff --git a/lib/resources/IssuerFraudRecords.js b/lib/resources/IssuerFraudRecords.js new file mode 100644 index 0000000000..10afd3feed --- /dev/null +++ b/lib/resources/IssuerFraudRecords.js @@ -0,0 +1,15 @@ +'use strict'; + +var StripeResource = require('../StripeResource'); +var stripeMethod = StripeResource.method; + +module.exports = StripeResource.extend({ + path: 'issuer_fraud_records', + includeBasic: ['list', 'retrieve'], + + retrieveFromCharge: stripeMethod({ + method: 'GET', + path: '', + urlParams: ['chargeId'], + }), +}); diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js new file mode 100644 index 0000000000..d5db7763c7 --- /dev/null +++ b/test/resources/IssuerFraudRecords.spec.js @@ -0,0 +1,39 @@ +'use strict'; + +var stripe = require('../testUtils').getSpyableStripe(); +var expect = require('chai').expect; + +describe('IssuerFraudRecord Resource', function() { + describe('retrieve', function() { + it('Sends the correct request for issfr ID', function() { + stripe.issuer_fraud_records.retrieve('issfr_123'); + expect(stripe.LAST_REQUEST).to.deep.equal({ + method: 'GET', + url: '/v1/issuer_fraud_records/issfr_123', + data: {}, + headers: {}, + }); + }); + it('Sends the correct request for charge ID', function() { + stripe.issuer_fraud_records.retrieve('ch_123'); + expect(stripe.LAST_REQUEST).to.deep.equal({ + method: 'GET', + url: '/v1/issuer_fraud_records?charge=ch_123', + data: {}, + headers: {}, + }); + }); + }); + + describe('list', function() { + it('Sends the correct request', function() { + stripe.issuer_fraud_records.list(); + expect(stripe.LAST_REQUEST).to.deep.equal({ + method: 'GET', + url: '/v1/issuer_fraud_records', + data: {}, + headers: {}, + }); + }); + }); +}); From 0b76b0b8a4789fb75d6e35483f36d4704e2a0a9a Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Mon, 7 May 2018 15:46:43 -0700 Subject: [PATCH 2/6] typo --- test/resources/IssuerFraudRecords.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js index d5db7763c7..a43aa4d3c5 100644 --- a/test/resources/IssuerFraudRecords.spec.js +++ b/test/resources/IssuerFraudRecords.spec.js @@ -15,7 +15,7 @@ describe('IssuerFraudRecord Resource', function() { }); }); it('Sends the correct request for charge ID', function() { - stripe.issuer_fraud_records.retrieve('ch_123'); + stripe.issuer_fraud_records.retrieveFromCharge('ch_123'); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', url: '/v1/issuer_fraud_records?charge=ch_123', From 475a42becb62360357fd4db0a5a0db5fea3040aa Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Wed, 9 May 2018 11:05:04 -0700 Subject: [PATCH 3/6] Edits --- lib/resources/IssuerFraudRecords.js | 4 +++- lib/stripe.js | 1 + test/resources/IssuerFraudRecords.spec.js | 9 +++++---- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/resources/IssuerFraudRecords.js b/lib/resources/IssuerFraudRecords.js index 10afd3feed..eccb7c0836 100644 --- a/lib/resources/IssuerFraudRecords.js +++ b/lib/resources/IssuerFraudRecords.js @@ -9,7 +9,9 @@ module.exports = StripeResource.extend({ retrieveFromCharge: stripeMethod({ method: 'GET', - path: '', + path: function(urlData) { + return '?charge=' + urlData.chargeId; + }, urlParams: ['chargeId'], }), }); diff --git a/lib/stripe.js b/lib/stripe.js index 5d67234ea2..61569a98a0 100644 --- a/lib/stripe.js +++ b/lib/stripe.js @@ -42,6 +42,7 @@ var resources = { ExchangeRates: require('./resources/ExchangeRates'), Invoices: require('./resources/Invoices'), InvoiceItems: require('./resources/InvoiceItems'), + IssuerFraudRecords: require('./resources/IssuerFraudRecords'), LoginLinks: require('./resources/LoginLinks'), Payouts: require('./resources/Payouts'), Plans: require('./resources/Plans'), diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js index a43aa4d3c5..d88b14b8f2 100644 --- a/test/resources/IssuerFraudRecords.spec.js +++ b/test/resources/IssuerFraudRecords.spec.js @@ -6,7 +6,7 @@ var expect = require('chai').expect; describe('IssuerFraudRecord Resource', function() { describe('retrieve', function() { it('Sends the correct request for issfr ID', function() { - stripe.issuer_fraud_records.retrieve('issfr_123'); + stripe.issuerFraudRecords.retrieve('issfr_123'); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', url: '/v1/issuer_fraud_records/issfr_123', @@ -15,10 +15,11 @@ describe('IssuerFraudRecord Resource', function() { }); }); it('Sends the correct request for charge ID', function() { - stripe.issuer_fraud_records.retrieveFromCharge('ch_123'); + stripe.issuerFraudRecords.retrieveFromCharge('ch_123456789'); + console.log(stripe); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', - url: '/v1/issuer_fraud_records?charge=ch_123', + url: '/v1/issuer_fraud_records?charge=ch_123456789', data: {}, headers: {}, }); @@ -27,7 +28,7 @@ describe('IssuerFraudRecord Resource', function() { describe('list', function() { it('Sends the correct request', function() { - stripe.issuer_fraud_records.list(); + stripe.issuerFraudRecords.list(); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', url: '/v1/issuer_fraud_records', From acb67e4bb9002dd6e3f6638cd5caf3f918ce85cc Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Wed, 9 May 2018 11:29:05 -0700 Subject: [PATCH 4/6] Get the list from charge working --- lib/resources/IssuerFraudRecords.js | 20 ++++++++++++++++---- test/resources/IssuerFraudRecords.spec.js | 3 +-- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/lib/resources/IssuerFraudRecords.js b/lib/resources/IssuerFraudRecords.js index eccb7c0836..122aad986d 100644 --- a/lib/resources/IssuerFraudRecords.js +++ b/lib/resources/IssuerFraudRecords.js @@ -4,13 +4,25 @@ var StripeResource = require('../StripeResource'); var stripeMethod = StripeResource.method; module.exports = StripeResource.extend({ - path: 'issuer_fraud_records', - includeBasic: ['list', 'retrieve'], + path: '', - retrieveFromCharge: stripeMethod({ + list: stripeMethod({ + method: 'GET', + path: 'issuer_fraud_records', + }), + + retrieve: stripeMethod({ + method: 'GET', + path: function(urlData) { + return 'issuer_fraud_records/' + urlData.issfrId; + }, + urlParams: ['issfrId'], + }), + + listFromCharge: stripeMethod({ method: 'GET', path: function(urlData) { - return '?charge=' + urlData.chargeId; + return 'issuer_fraud_records?charge=' + urlData.chargeId; }, urlParams: ['chargeId'], }), diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js index d88b14b8f2..35ee527adb 100644 --- a/test/resources/IssuerFraudRecords.spec.js +++ b/test/resources/IssuerFraudRecords.spec.js @@ -15,8 +15,7 @@ describe('IssuerFraudRecord Resource', function() { }); }); it('Sends the correct request for charge ID', function() { - stripe.issuerFraudRecords.retrieveFromCharge('ch_123456789'); - console.log(stripe); + stripe.issuerFraudRecords.listFromCharge('ch_123456789'); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', url: '/v1/issuer_fraud_records?charge=ch_123456789', From 750a8ed90d36e0dbf1f1196fe216b4d2d29b0d28 Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Wed, 9 May 2018 13:40:01 -0700 Subject: [PATCH 5/6] Put charge retrieve in list --- lib/resources/IssuerFraudRecords.js | 24 ++--------------------- test/resources/IssuerFraudRecords.spec.js | 18 ++++++++--------- 2 files changed, 11 insertions(+), 31 deletions(-) diff --git a/lib/resources/IssuerFraudRecords.js b/lib/resources/IssuerFraudRecords.js index 122aad986d..76c1e1e4d0 100644 --- a/lib/resources/IssuerFraudRecords.js +++ b/lib/resources/IssuerFraudRecords.js @@ -1,29 +1,9 @@ 'use strict'; var StripeResource = require('../StripeResource'); -var stripeMethod = StripeResource.method; module.exports = StripeResource.extend({ - path: '', + path: 'issuer_fraud_records', - list: stripeMethod({ - method: 'GET', - path: 'issuer_fraud_records', - }), - - retrieve: stripeMethod({ - method: 'GET', - path: function(urlData) { - return 'issuer_fraud_records/' + urlData.issfrId; - }, - urlParams: ['issfrId'], - }), - - listFromCharge: stripeMethod({ - method: 'GET', - path: function(urlData) { - return 'issuer_fraud_records?charge=' + urlData.chargeId; - }, - urlParams: ['chargeId'], - }), + includeBasic: ['list', 'retrieve'], }); diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js index 35ee527adb..51882cf683 100644 --- a/test/resources/IssuerFraudRecords.spec.js +++ b/test/resources/IssuerFraudRecords.spec.js @@ -14,15 +14,6 @@ describe('IssuerFraudRecord Resource', function() { headers: {}, }); }); - it('Sends the correct request for charge ID', function() { - stripe.issuerFraudRecords.listFromCharge('ch_123456789'); - expect(stripe.LAST_REQUEST).to.deep.equal({ - method: 'GET', - url: '/v1/issuer_fraud_records?charge=ch_123456789', - data: {}, - headers: {}, - }); - }); }); describe('list', function() { @@ -35,5 +26,14 @@ describe('IssuerFraudRecord Resource', function() { headers: {}, }); }); + it('Sends the correct request for charge ID', function() { + stripe.issuerFraudRecords.list({charge: 'ch_123456789'}); + expect(stripe.LAST_REQUEST).to.deep.equal({ + method: 'GET', + url: '/v1/issuer_fraud_records', + data: {charge: 'ch_123456789'}, + headers: {}, + }); + }); }); }); From d4068a4caa732341fe108c9d4aeb21513e94dc34 Mon Sep 17 00:00:00 2001 From: Fay Wu Date: Wed, 9 May 2018 15:08:03 -0700 Subject: [PATCH 6/6] Edit tests --- test/resources/IssuerFraudRecords.spec.js | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/test/resources/IssuerFraudRecords.spec.js b/test/resources/IssuerFraudRecords.spec.js index 51882cf683..2a604e68b9 100644 --- a/test/resources/IssuerFraudRecords.spec.js +++ b/test/resources/IssuerFraudRecords.spec.js @@ -5,7 +5,7 @@ var expect = require('chai').expect; describe('IssuerFraudRecord Resource', function() { describe('retrieve', function() { - it('Sends the correct request for issfr ID', function() { + it('Sends the correct request', function() { stripe.issuerFraudRecords.retrieve('issfr_123'); expect(stripe.LAST_REQUEST).to.deep.equal({ method: 'GET', @@ -26,14 +26,5 @@ describe('IssuerFraudRecord Resource', function() { headers: {}, }); }); - it('Sends the correct request for charge ID', function() { - stripe.issuerFraudRecords.list({charge: 'ch_123456789'}); - expect(stripe.LAST_REQUEST).to.deep.equal({ - method: 'GET', - url: '/v1/issuer_fraud_records', - data: {charge: 'ch_123456789'}, - headers: {}, - }); - }); }); });