Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access full card number in onCardChange callback #280

Closed
obates opened this issue May 27, 2021 · 7 comments · Fixed by #306
Closed

Access full card number in onCardChange callback #280

obates opened this issue May 27, 2021 · 7 comments · Fixed by #306
Labels
enhancement New feature or request P1 Address these issues second

Comments

@obates
Copy link

obates commented May 27, 2021

Is your feature request related to a problem? Please describe.
We use Stripe to take card payments, and a 2nd payment provider to send money to a card. We want to use the Stripe Card component to collect card details & submit them to both Stripe and the 2nd payment provider at the same time (fully PCI compliant).

In order to do this, we require access to the full card details (number, expiry, etc) for sending.

Currently, the stripe-react-native library explicitly hides the full card number from the onCardChange callback, despite this being a feature in the respective native libraries (#68).

Describe the solution you'd like
Expose the full card number in the onCardChange callback, to align with the native iOS/Android libraries.

To address the concerns in the comments in the above-linked PR (#68 (comment)), an additional prop could be added to the card component e.g. dangerouslyGetFullCardDetails?

Many thanks,
Oli

@obates obates changed the title Access full cardNumber Access full card number in onCardChange callback May 27, 2021
@thorsten-stripe thorsten-stripe added enhancement New feature or request need triage labels May 27, 2021
@thorsten-stripe
Copy link
Contributor

Yes, I think that's a reasonable request, I'll discuss with the team.

@obates
Copy link
Author

obates commented Jun 2, 2021

Thanks @thorsten-stripe - any ideas on when this could happen? I'm happy to add a pull request if you think the above suggestion is sensible

@thorsten-stripe thorsten-stripe added P1 Address these issues second and removed enhancement New feature or request labels Jun 2, 2021
@thorsten-stripe
Copy link
Contributor

We're working on this now. It will be part of the v0.1.3 release later this week.

@thorsten-stripe
Copy link
Contributor

@obates you don't need access to the CVC, correct? I don't see a usecase where you would, but do let me know if I'm wrong.

@obates
Copy link
Author

obates commented Jun 3, 2021

@obates you don't need access to the CVC, correct? I don't see a usecase where you would, but do let me know if I'm wrong.

Correct. Thanks for jumping on this so fast

@juanolmedogl
Copy link

juanolmedogl commented Jun 22, 2021

@obates you don't need access to the CVC, correct? I don't see a usecase where you would, but do let me know if I'm wrong.

@thorsten-stripe I'm only using the CardField component to collect data and then calling stripe API's directly.
Is it possible to add the CVC value to the callback ?

I was thinking that the CVC field could be accessible when dangerouslyGetFullCardDetails is set to true (like the card number).

Please let me know.
Thanks!

@tluber
Copy link

tluber commented Jul 13, 2021

@obates you don't need access to the CVC, correct? I don't see a usecase where you would, but do let me know if I'm wrong.

@thorsten-stripe I'm only using the CardField component to collect data and then calling stripe API's directly.
Is it possible to add the CVC value to the callback ?

I was thinking that the CVC field could be accessible when dangerouslyGetFullCardDetails is set to true (like the card number).

Please let me know.
Thanks!

Same as @juanolmedogl. It would be nice to have access to the CVC field!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Address these issues second
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants