Skip to content

Commit

Permalink
Use all nan values to represent a null QgsRectangle
Browse files Browse the repository at this point in the history
This was suggested by Benoit in
qgis#54646 (comment)
  • Loading branch information
strk committed Oct 23, 2023
1 parent 1d1b7c9 commit 52765a3
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/core/geometry/qgsrectangle.h
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,7 @@ class CORE_EXPORT QgsRectangle
*/
void setNull() SIP_HOLDGIL
{
mXmin = mYmin = std::numeric_limits<double>::max();
mXmax = mYmax = -std::numeric_limits<double>::max();
mXmin = mYmin = mXmax = mYmax = std::numeric_limits< double >::quiet_NaN();
}

/**
Expand Down Expand Up @@ -648,10 +647,10 @@ class CORE_EXPORT QgsRectangle

private:

double mXmin = std::numeric_limits<double>::max();
double mYmin = std::numeric_limits<double>::max();
double mXmax = -std::numeric_limits<double>::max();
double mYmax = -std::numeric_limits<double>::max();
double mXmin = std::numeric_limits< double >::quiet_NaN();
double mYmin = std::numeric_limits< double >::quiet_NaN();
double mXmax = std::numeric_limits< double >::quiet_NaN();
double mYmax = std::numeric_limits< double >::quiet_NaN();

};

Expand Down

0 comments on commit 52765a3

Please sign in to comment.