From a3e7fa92d2ba7470651bc75eebaec53f988a906b Mon Sep 17 00:00:00 2001 From: Sandro Santilli Date: Thu, 19 Oct 2023 15:35:28 +0200 Subject: [PATCH] Use all nan values to represent a null QgsRectangle This was suggested by Benoit in https://github.com/qgis/QGIS/pull/54646#discussion_r1330107062 --- src/core/geometry/qgsrectangle.h | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/core/geometry/qgsrectangle.h b/src/core/geometry/qgsrectangle.h index 5ae5aacc6e28..3c74f40bdadb 100644 --- a/src/core/geometry/qgsrectangle.h +++ b/src/core/geometry/qgsrectangle.h @@ -175,8 +175,7 @@ class CORE_EXPORT QgsRectangle */ void setNull() SIP_HOLDGIL { - mXmin = mYmin = std::numeric_limits::max(); - mXmax = mYmax = -std::numeric_limits::max(); + mXmin = mYmin = mXmax = mYmax = std::numeric_limits< double >::quiet_NaN(); } /** @@ -641,10 +640,10 @@ class CORE_EXPORT QgsRectangle private: - double mXmin = std::numeric_limits::max(); - double mYmin = std::numeric_limits::max(); - double mXmax = -std::numeric_limits::max(); - double mYmax = -std::numeric_limits::max(); + double mXmin = std::numeric_limits< double >::quiet_NaN(); + double mYmin = std::numeric_limits< double >::quiet_NaN(); + double mXmax = std::numeric_limits< double >::quiet_NaN(); + double mYmax = std::numeric_limits< double >::quiet_NaN(); };