Allow skipShapeProps in react/no-unused-prop-types

[danielkraus]

Why do we have skipShapeProps: false for this rule?

Let's say I have:

Navigation.propTypes = {
 links: PropTypes.arrayOf(
    PropTypes.shape({
      url: PropTypes.string.required,
      label: PropTypes.string.isRequired,
    })
  ).isRequired,
 categoryTitle: PropTypes.string.isRequired,
}

Then I get

[eslint] 'links.*.url' PropType is defined but prop is never used (react/no-unused-prop-types)

I think we should set skipShapeProps to true. Or am I missing something? I found the similar issue that describes the problem more for example here jsx-eslint/eslint-plugin-react#819.

[robertrossmann]

@dannytce indeed, why? I thought skipping any type of props validation is not a good thing but if you guys have valid reasons to turn that option off I'm okay with it.

[robertrossmann]

ping @dannytce.

[petrhanak]

@robertrossmann Rule react/no-unused-prop-types is broken. It should be set to only warning level with skipShapeProps: true as it is causing a lot of false positives.

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unused-prop-types.md#known-issueslimitations

Details discussed here jsx-eslint/eslint-plugin-react#976

[robertrossmann]

Fixed in 7.5.0 🎉