fix(MutantRunResultMatcher): False positive fix #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using @types dev dependencies * Update estree node structure in mutator module * Remove dependency on typings
* Make use of ts2 type narrowing * Rename module 'stryker-api/estree' back to 'estree'
* Update mutators by injecting the new signature of the copy function. This allows us to remove most of the type castings.
Mostely: * Semicolon * Whitespaces * double quotes <> single quotes
* Removed unused other stryker dependencies
When a mutant alters something smaller than an exact statement, it was reported as `untested`, well in fact it was covered. * Fixed the algoritm * Add a test to prevent regression
|
I just did the test on @bkimminich's juice-shop and with test selector gives the same result as without. Also, the original reported false positive now also gets killed. A thing of absolute beauty 👍 |
# Conflicts: # package.json # src/MutatorOrchestrator.ts # src/mutators/RemoveConditionalsMutator.ts # test/unit/mutators/RemoveConditionalsMutatorSpec.ts # testResources/module/package.json
nicojs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mutant alters something smaller than an exact statement, it was reported as
untested, well in fact it was covered.Fix for #151