Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button prop types are behaving as any #133

Closed
jamcry opened this issue Jul 19, 2021 · 0 comments
Closed

Button prop types are behaving as any #133

jamcry opened this issue Jul 19, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jamcry
Copy link
Collaborator

jamcry commented Jul 19, 2021

Currently, I can give any prop to Button, It won't raise an error. Also autocomplete not working. See:

Screen Shot 2021-07-19 at 4 33 00 PM

I believe it is because of the second argument (Record<string, any>) here (in Button.tsx):

const Button = React.forwardRef<HTMLButtonElement, Record<string, any>>

Maybe we can pass ButtonProps instead of Record<string, any>

@jamcry jamcry added the bug Something isn't working label Jul 19, 2021
@mucahit mucahit closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants