Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird interaction with storybook 5 breaks compilation #212

Closed
cellog opened this issue Mar 10, 2019 · 1 comment
Closed

weird interaction with storybook 5 breaks compilation #212

cellog opened this issue Mar 10, 2019 · 1 comment

Comments

@cellog
Copy link

cellog commented Mar 10, 2019

As referenced here: storybookjs/storybook#5882

Greenkeeper asked us to upgrade from 4.1 to 5.0 of storybook, and now, suddenly, we get failures where the styled components babel plugin is replacing imports with declarations:

ERROR in ./src/components/creator/lock/KeyList.js 13:15
Module parse failed: Unexpected keyword 'var' (13:15)
You may need an appropriate loader to handle this file type.
| import { connect } from 'react-redux';
| import styled from 'styled-components';
> import Link, { var _ref3 =
| /*#__PURE__*/
| React.createElement(Message, {
 @ ./src/stories/creator/KeyList.stories.js 5:0-64 37:29-36 49:29-36 61:29-36 73:29-36 85:29-36
 @ ./src/stories sync \.stories\.js$
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js (webpack)-hot-middleware/client.js?reload=true

The PR that shows these errors is unlock-protocol/unlock#1877

I have not yet tried to isolate this, would love some ideas of why this might be happening so I know what to isolate.

@quantizor
Copy link
Collaborator

Closing as it appears to be a storybook issue reading through the linked thread that is now closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants