Skip to content
This repository has been archived by the owner on Jun 30, 2024. It is now read-only.

Add a colon and semicolon, as well as trigger property value completion after rule name completion #220

Closed
michaelschufi opened this issue May 20, 2020 · 14 comments · Fixed by #284

Comments

@michaelschufi
Copy link

michaelschufi commented May 20, 2020

Currently we lose out on some of VS Codes' CSS auto-completion UX. There are some features I really miss using styled-components opposed to CSS/LESS/SCSS files. (see also this issue)

After selecting/completing the rule name, it should:

  • Add a colon after the rule name
  • Add a semicolon at the end of the line
  • Trigger the property value completion for the completed rule

As shown here

image

@michaelschufi michaelschufi changed the title Add colon and semicolon on value completion and trigger property value completion Add colon and semicolon and trigger property value completion after rule name completion May 20, 2020
@michaelschufi michaelschufi changed the title Add colon and semicolon and trigger property value completion after rule name completion Add a colon and semicolon, as well as trigger property value completion after rule name completion May 20, 2020
@ftzi
Copy link

ftzi commented May 22, 2020

This is a must do. It annoys me that we have to manually insert the semicolon, even after saves.

But, is a nice extension!

@golfomania
Copy link

started today to learn about styled components (dev eds react course) and i totally agree, that this extended autocomplete would be great.

@seb-thomas
Copy link

#172 (comment)

Fork works

@NayamAmarshe
Copy link

#172 (comment)

Fork works

But it's based on an older version and doesn't support newer features like color highlighting.

@NayamAmarshe
Copy link

Currently we lose out on some of VS Codes' CSS auto-completion UX. There are some features I really miss using styled-components opposed to CSS/LESS/SCSS files. (see also this issue)

This is the only thing that's making me hate styled components compared to node-sass

@jasonwilliams
Copy link
Collaborator

@jasonwilliams
Copy link
Collaborator

This should be released in v1.6.0

@jasonwilliams
Copy link
Collaborator

This has now been released, ive added a gif to the readme to showcase

@NayamAmarshe
Copy link

This has now been released, ive added a gif to the readme to showcase

Thanks a lot!

@Diagonet
Copy link

I see this has already been added but I can't seem to get proper autocomplete and colon/simicolon. All I want is the same behavior I can see in the gif, is there anything that could be interfering with it?

@jasonwilliams
Copy link
Collaborator

I see this has already been added but I can't seem to get proper autocomplete and colon/simicolon. All I want is the same behavior I can see in the gif, is there anything that could be interfering with it?

@Diagonet please raise a new bug issue with a screenshot and code for reproducing

@jasonwilliams
Copy link
Collaborator

@Diagonet i think microsoft/typescript-styled-plugin#156 may fix your issue

@Diagonet
Copy link

Yeah so, I found out I only get the proper semi-colon auto complete when I use Enter to auto complete (even thought I changed the vscode setting for Tab auto completion)

@timbam
Copy link

timbam commented Mar 10, 2023

For anyone it can help, I had the same problem as Diagonet. Found out there's a styled-components shortcut that was set to enter instead of tab:
@ext:styled-components.vscode-styled-components

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants