-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Docusaurus 2 #125
Comments
Looks good idea! |
The Docusaurus team will be sending Facebook Open Source stickers to contributors who successfully complete migrate a website. |
I'll try to work on this issue! |
Great! Thanks @sasurau4! |
Hmm? This is a bit strange, why are the documents separated into two repositories? |
It's probably a good idea to create a website directory in the root directory of the stylelint repository. |
@imbsky I'm not sure about the original reason for the separation, but I think it has worked well and is reasonable. When we'd like to publish a new version of stylelint, we can just update Line 103 in 8f6a1cd
Also, the separation has an advantage which stylelint/stylelint doesn't need to have extra dependencies. |
@ybiquitous The Redux documentation is probably a good example. We replaced that recently. In this case, the extra dependencies are not a problem. |
Yes, I think either way is reasonable and has own pros and cons. 😃 Anyway, it's a big task to move this repo to stylelint/stylelint. So if you'd like to achieve it, I think you will need to convince our community. |
Certainly, I just checked all of this repository and it seems to work well. Let's migrate to alpha without moving to main repository! |
Sorry to do this, it's late here Friday night for me but I'm locking down this conversation, apologies for the lack of explaining the reason right now and I will follow up tomorrow with a full explanation We will not be migrating to Docusaurus 2 Alpha |
I wouldn't migrate to alpha version of anything. It's not that stable and might have breaking changes at any point. Let's stick to stable releases. |
They aren't. The documentation lives within the main repo: Only the code needed to transform these docs into a website lives in this repo.
Agreed. |
For example, Redux has migrated to Docusaurus v2 and the website seems to work well. So, if we could get the help of the Docusaurus team for our complete migration well and continuously, I think it attractive personally. However, if not a few people are concerned about using the alpha version, I will follow the community's decision. In addition, because the stylelint/stylelint.io repository is a little different from typical documentation which Docusaurus would assume, the migration may not be able to proceed smoothly. Here are the different points:
|
The Docusaurus team have a list of who and who shouldn't use the alpha. If you or some else is willing to champion the use of the alpha, i.e. put the legwork in over the course of the alpha, then you have my vote. As you said, it'll allow us to feedback our use case to the Docusaurus team.
We've never had the time nor the design resources to build a custom website homepage. That might change in the future. At the moment, the current approach works. stylelint/stylelint#4548 refines the README.md too. |
All right, let's wait until the stable release. |
Yes, I agree 👍 |
I was curious, so I opened a draft PR updating the site to Docusaurus v2. We can leave it open until v2 is out of alpha. If you're curious too, here's the deploy preview and the PR. |
Good news! 🎉
Announcing Docusaurus 2 Beta: BTW, Docusaurus v1 depends on outdated |
Excellent. I think it's time to pick up #174, if anyone fancies it. The deploy preview looks almost functionally there. I think we need to fix the rule pages:
Once they are in place, we can look at tidying up some of the styles, especially around dark mode. We'll probably want to keep things as close to the default theme to make things easy for us. |
Hi there! The Docusaurus team is currently developing Docusaurus 2 and are almost done with an MVP that doesn't include translations and versioning features, which means there's feature parity with our website's current usage of Docusaurus.
Docusaurus 2 brings about many improvements:
I will be helping you migrate and be the POC throughout the migration process. Let me know what you think!
cc @yangshun @wgao19
The text was updated successfully, but these errors were encountered: