Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is iconic for? #21

Closed
curvedmark opened this issue Jul 12, 2011 · 9 comments
Closed

What is iconic for? #21

curvedmark opened this issue Jul 12, 2011 · 9 comments

Comments

@curvedmark
Copy link

Does it mean to help user create icons?

Why not create a font-face function so the user can use whatever font she wants?

I'd be happy to add a font-face function if you think it will be worth it.

@tj
Copy link
Collaborator

tj commented Jul 12, 2011

yup that's what it's for, i'd be down for abstracting that out a bit though like you say

@curvedmark
Copy link
Author

Just realize a font-face mixin is going to have a lot of arguments: font-family, multiple srcs, font-style, font-weight, font-stretch, etc. Any suggestions on the API?

@curvedmark
Copy link
Author

oh, one more thing. do you approve the logic used in compass? I'm going to shamelessly copy that if you think what they did is right. :)

@curvedmark
Copy link
Author

btw, they only support font-family and multiple srcs. I'm not sure if we should copy that too or support everything documented in w3c.

@tj
Copy link
Collaborator

tj commented Jul 18, 2011

hmm probably best to keep it simple for now, I haven't seen the compass one

@curvedmark
Copy link
Author

Actually, the only part in @font-face that needs abstraction is src, if you look at this syntax. So maybe we can just create a mixin for src and not wrap the whole @font-face rule? For example,

@font-face
    font-family Geo
    font-style normal
    font-src myfont-webfont

font-src is a mixin that produces font urls for different font types (and if support-for-ie is false, it doesn't produce url for eot font).

What do you think?

@kmiyashiro
Copy link

If you want to make it better than compass/fontsquirrel, allow definition of font-weight src files so you don't have to use different font-families for different weights. This keeps it simple for the developer.

http://www.456bereastreet.com/archive/201012/font-face_tip_define_font-weight_and_font-style_to_keep_your_css_simple/

@curvedmark
Copy link
Author

@kmiyashiro I don't think this is something should be handled in the framework layer. You can easy do this

@font-face
    font-family 'DroidSerif';
    font-src DroidSerif-Regular-webfont
    font-weight normal;
    font-style normal;
@font-face
    font-family 'DroidSerif'
    font-src DroidSerif-Italic-webfont
    font-weight normal
    font-style italic
...

I never knew this technique though. Thanks for link.

@notslang
Copy link
Collaborator

This issue hasn't been active for 2 years, so I'm closing this. If you think it is still an issue; reopen. [slang-bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants