Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Faker::Dog and add tests #1082

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Fix Faker::Dog and add tests #1082

merged 2 commits into from
Dec 4, 2017

Conversation

wtanna
Copy link

@wtanna wtanna commented Dec 3, 2017

This PR Does the following:

  • Faker::Dog was actually Faker::Cat. Updated to the correct class name
  • Added more random data to Faker::Dog
  • Added tests for Faker::Dog
  • Updated the Regex in Faker::University to check for Greek Letters. CI kept failing because when it was generating the 3 letter greek_organization they were all Greek Letters and not word characters \w. There is a chance that one character could be a word character, allowing the tests to pass. I was just very unlucky it seems.

@stympy stympy merged commit e0a5421 into faker-ruby:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants