Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SingularSiegler quotes #1129

Merged
merged 5 commits into from
May 21, 2018
Merged

Added SingularSiegler quotes #1129

merged 5 commits into from
May 21, 2018

Conversation

splashinn
Copy link
Contributor

  • This is a collection of quotes from a co-worker

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Thanks for contributing 🥇

@vbrazo vbrazo force-pushed the master branch 4 times, most recently from 6394a28 to d11bd7e Compare May 20, 2018 20:41
@vbrazo vbrazo merged commit e0e8594 into faker-ruby:master May 21, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:25
@splashinn
Copy link
Contributor Author

Why was this removed from the gem? Just curious.

@Zeragamba
Copy link
Contributor

Looks like it wasn't removed, just moved to Faker::Quotes.singular_siegler

davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* added my contribution to ReadMe contents section

* added md file for docs - singular siegler

* added singular_siegler.rb

* added quotes file for singular siegler

* added test file for singular siegler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants