Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample output of Faker::App.version. #1204

Merged
merged 2 commits into from
May 18, 2018

Conversation

joshuapinter
Copy link
Contributor

To better distinguish between Faker::App.version and Faker::App.semantic_version. The former can be semantic but not necessarily:

irb(main):001:0> Faker::App.version
=> "0.39"
irb(main):002:0> Faker::App.version
=> "8.3.9"
irb(main):003:0> Faker::App.version
=> "0.38"
irb(main):004:0> Faker::App.version
=> "2.2.3"
irb(main):005:0> Faker::App.version
=> "9.1.4"
irb(main):006:0> Faker::App.version
=> "4.17"
irb(main):007:0> Faker::App.version
=> "1.85"
irb(main):008:0> Faker::App.version
=> "9.72"
irb(main):009:0> Faker::App.version
=> "1.9"
irb(main):010:0> Faker::App.version
=> "0.42"
irb(main):011:0> Faker::App.version
=> "2.95"
irb(main):012:0> Faker::App.version
=> "0.7.8"
irb(main):013:0> Faker::App.version
=> "8.5"

This helps people grok the difference easier.

Verified

This commit was signed with the committer’s verified signature.
Robbepop Robin Freyler
To better distinguish between `Faker::App.version` and `Faker::App.semantic_version`. The former can be semantic but not necessarily: 

```ruby
irb(main):001:0> Faker::App.version
=> "0.39"
irb(main):002:0> Faker::App.version
=> "8.3.9"
irb(main):003:0> Faker::App.version
=> "0.38"
irb(main):004:0> Faker::App.version
=> "2.2.3"
irb(main):005:0> Faker::App.version
=> "9.1.4"
irb(main):006:0> Faker::App.version
=> "4.17"
irb(main):007:0> Faker::App.version
=> "1.85"
irb(main):008:0> Faker::App.version
=> "9.72"
irb(main):009:0> Faker::App.version
=> "1.9"
irb(main):010:0> Faker::App.version
=> "0.42"
irb(main):011:0> Faker::App.version
=> "2.95"
irb(main):012:0> Faker::App.version
=> "0.7.8"
irb(main):013:0> Faker::App.version
=> "8.5"
```

This helps people grok the difference easier.
@joshuapinter
Copy link
Contributor Author

Is there something you want me to do with this?

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the changelog.md and include the title of this PR + your GitHub ID.

@joshuapinter
Copy link
Contributor Author

Done! :)

@coveralls
Copy link

coveralls commented May 18, 2018

Pull Request Test Coverage Report for Build 2152

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.647%

Totals Coverage Status
Change from base Build 2135: 0.01%
Covered Lines: 2260
Relevant Lines: 2268

💛 - Coveralls

@faker-ruby faker-ruby deleted a comment from coveralls May 18, 2018
@vbrazo vbrazo merged commit 7c4db2a into faker-ruby:master May 18, 2018
@joshuapinter
Copy link
Contributor Author

👍

@joshuapinter joshuapinter deleted the patch-2 branch May 18, 2018 00:23
@vbrazo vbrazo self-requested a review July 19, 2018 01:40
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* Update sample output of `Faker::App.version`.

To better distinguish between `Faker::App.version` and `Faker::App.semantic_version`. The former can be semantic but not necessarily: 

```ruby
irb(main):001:0> Faker::App.version
=> "0.39"
irb(main):002:0> Faker::App.version
=> "8.3.9"
irb(main):003:0> Faker::App.version
=> "0.38"
irb(main):004:0> Faker::App.version
=> "2.2.3"
irb(main):005:0> Faker::App.version
=> "9.1.4"
irb(main):006:0> Faker::App.version
=> "4.17"
irb(main):007:0> Faker::App.version
=> "1.85"
irb(main):008:0> Faker::App.version
=> "9.72"
irb(main):009:0> Faker::App.version
=> "1.9"
irb(main):010:0> Faker::App.version
=> "0.42"
irb(main):011:0> Faker::App.version
=> "2.95"
irb(main):012:0> Faker::App.version
=> "0.7.8"
irb(main):013:0> Faker::App.version
=> "8.5"
```

This helps people grok the difference easier.

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants