Add paragraph_by_chars functionality #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguthrie100
changed the title
jguthrie100
changed the title
vbrazo
reviewed
May 20, 2018
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| **Additions** | |||
|
|
|||
| - [PR #1222](https://github.com/stympy/faker/pull/1222) Add paragraph_by_chars functionality [@jguthrie100](https://github.com/jguthrie100) | |||
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a359def to
a5d7731
Compare
vbrazo
force-pushed
the
add_paragraph_by_chars
branch
from
2fad140 to
ecad86b
Compare
vbrazo
approved these changes
May 28, 2018
There was a problem hiding this comment.
Thanks for contributing 💯
Overall looks good. I just pushed a few small things 👍
Since you are a new contributor, you should read our contributors file.
vbrazo
force-pushed
the
add_paragraph_by_chars
branch
from
8c42c19 to
b43d09a
Compare
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Added paragraph_by_chars function and tests * Update CHANGELOG * Add missing documentation and fix test * Minor changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicated PR #1079 (committed changes to dedicated branch which is much easier to handle!)