Add missing tests reported by SimpleCov #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
reviewed
May 24, 2018
| @@ -70,8 +68,6 @@ def random_complex_type | |||
| rb_hash | |||
| when :array | |||
| rb_array | |||
| else | |||
| rb_integer | |||
| end | |||
There was a problem hiding this comment.
By reading the code, I noticed that the code will never pass in the else statements, therefore I believe we should just delete the statements.
There was a problem hiding this comment.
Those else statements give a bit more flexibility to quickly edit the constants in the class. But I wasn't sure if that's worth not getting 100% test coverage. Thanks for clarifying that!
There was a problem hiding this comment.
Well, the code is basically working with the values inside the SIMPLE_TYPES and COMPLEX_TYPES arrays and as we can see, integer isn't declared.
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Add some tests * Add more tests * Remove unnecessary else statements * Add faker unique generator missing test * Add more unique generator tests * Update changelog.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for issue #1233 created by @vbrazo
Current Coverage
was: 98.86% | is: 99.18%