Add Faker::WorldCup

[snayrouz]

I'm having an issue when I run bundle exec rake
I receive a "rake aborted" notification and a lot of failing tests.
I'm wondering if someone could take a look at this so I can run my tests. @olleolleolle @robbyrussell @garyharan @steveh @probablycorey

[vbrazo]

Thanks for contributing 🥇

You locales are invalid, you should remove the ,

group_A: ["Egypt", "Russia", "Saudi Arabia", "Uruguay"],

[vbrazo]

A few things that need to be done before merging:

• create a doc/world_cup.md. Check other files in this folder out.
• update readme.md and add the world_cup in the menu

Even though I fixed your locales and the multiple crashes, there are a few tests in the test_faker_world_cup.rb that are failing, so I'd recommend you pulling my changes and see what's going on.

We're using rubocop, so make sure to run bundle exec rubocop -a to autocorrect the rubocop violations before pushing.

[vbrazo]

@snayrouz I opened a console by running rake console. Your methods are not working properly.

Do that and run:

• Faker::WorldCup.group
• Faker::WorldCup.roster

Faker::WorldCup.team works fine.

[snayrouz]

@vbrazo thanks for taking a look and making changes! I should have prefaced in my PR that I wasn't ready to merge, just needed some help in regards to all the failing tests. I really appreciate your quick help as I'd love to get this merged before the first matches and see if anyone does anything fun with this library.. I'll probably wait to submit my final PR once the final rosters have been set for all teams June 4.

[vbrazo]

I think the solution would be:

# lib/faker/world_cup.rb
...
      def team
        fetch('world_cup.teams')
      end

      def group(group = 'group_A')
        fetch("world_cup.groups.#{group}")
      end

      def roster(country = 'Egypt', type = 'coach')
        fetch("world_cup.rosters.#{country}.#{type}")
      end
...

otherwise you won't be able to show the nested locales. I think you could finish this PR and just update the locales when the teams are set. It's up to me.

Let me know if you need any help in other PRs or explanations. Just tag me and I'll take a look asap. I'm here to help :)

[snayrouz]

@vbrazo that solution makes the tests pass, but with the hard coded group, country and type values, it will only generate those specific values from the library.

also thank you for your help!

[vbrazo]

@snayrouz the hardcoded will only be used when we don't pass the parameters. If you use Faker::WorldCup.roster, you'll be using the default params, but if you pass Faker::WorldCup.roster('Brazil', 'coach'), you should be able to retrieve the Brazilian coach.

It's pretty similar to this module.

[snayrouz]

You're right! 🤦🏻‍♂️

…

On Sat, Jun 2, 2018 at 9:26 AM Vitor ***@***.***> wrote: @snayrouz <https://github.com/snayrouz> the hardcoded will only be used when we don't pass the params. If you use Faker::WorldCup.roster, you'll be using the default params, but if you pass Faker::WorldCup.roster(country = 'Brazil', type = 'coach'), you'd be able to access the Brazilian coach. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1265 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AXdDIh4-cRkJ7Hr-WmlNu0xtgKewW68Lks5t4q7CgaJpZM4UXi4f> .

[vbrazo]

Feel free to open a new PR to update the locales @snayrouz