Adding Faker::Company.brazilian_company_number #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Thanks for contributing 👍
The logic looks ok to me, but I believe this method should be located in Faker::Company. Take a look at the Faker::Company methods. Faker::IDNumber should concentrate citizens and foreigners identification/ID from different nationalities.
I'd suggest moving this logic to the company object.
vbrazo
changed the title
|
Done, @vbrazo |
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Adding Faker::IDNumber.brazilian_company_number * fix compatibility for older ruby versions * moving from id number to company * updating docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds brazilian company number (CNPJ)