Random words to add should be 0 #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives very unexpected results, especially weird when validating max char length of a field
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
a359def to
a5d7731
Compare
vbrazo
approved these changes
May 30, 2018
vbrazo
reviewed
May 30, 2018
lib/faker/lorem.rb
Outdated
| def sentence(word_count = 4, supplemental = false, random_words_to_add = 6) | ||
| words(word_count + rand(random_words_to_add.to_i), supplemental).join(' ').capitalize + locale_period | ||
| def sentence(word_count = 4, supplemental = false, random_words_to_add = 0) | ||
| words(word_count + rand(random_words_to_add.to_i), supplemental).join(' ').capitalize + '.' |
There was a problem hiding this comment.
You shouldn't do this change, because the period punctuation is different in a few languages. That's why we have a locale_period private method. I'd suggest undoing this change and we can merge the rest @swapsCAPS
vbrazo
reviewed
May 30, 2018
lib/faker/lorem.rb
Outdated
| def question(word_count = 4, supplemental = false, random_words_to_add = 6) | ||
| words(word_count + rand(random_words_to_add.to_i), supplemental).join(locale_space).capitalize + locale_question_mark | ||
| def question(word_count = 4, supplemental = false, random_words_to_add = 0) | ||
| words(word_count + rand(random_words_to_add.to_i).to_i, supplemental).join(' ').capitalize + '?' |
There was a problem hiding this comment.
You can't do this change as well.
"In Greek, which uses the Greek alphabet, the question mark ";"is identical to the Latin semicolon: Πώς σας λένε;" credits to Quora
vbrazo
reviewed
May 30, 2018
lib/faker/lorem.rb
Outdated
| def paragraph(sentence_count = 3, supplemental = false, random_sentences_to_add = 3) | ||
| sentences(resolve(sentence_count) + rand(random_sentences_to_add.to_i), supplemental).join(locale_space) | ||
| def paragraph(sentence_count = 3, supplemental = false, random_sentences_to_add = 0) | ||
| sentences(resolve(sentence_count) + rand(random_sentences_to_add.to_i), supplemental).join(' ') |
There was a problem hiding this comment.
Space is space everywhere. I agree 👍
vbrazo
force-pushed
the
patch-default-random-sentence-length
branch
from
ad7704c to
dc4d3d2
Compare
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Random words to add should be 0 Gives very unexpected results, especially weird when validating max char length of a field * Merge with master and minor changes * Update changelog * Minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives very unexpected results, especially weird when validating max char length of a field