Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add -i flag to specify ignore files #492

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

r0mflip
Copy link
Contributor

@r0mflip r0mflip commented Jan 7, 2020

Fixes #428

Confirming to #428 (comment)

Closes #451.

@r0mflip r0mflip changed the title feat: Add -i flag to ignore files from gitignore feat: Add -i flag specify ignore files Jan 7, 2020
@r0mflip r0mflip changed the title feat: Add -i flag specify ignore files feat: Add -i flag to specify ignore files Jan 7, 2020
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'll do a cleanup pass on dotignore and publish a new patch if needed before merging this :-D)

Thanks, this is great!

bin/tape Outdated Show resolved Hide resolved
bin/tape Outdated Show resolved Hide resolved
bin/tape Outdated Show resolved Hide resolved
@ljharb ljharb added the semver-minor: new stuff Any additions. label Jan 7, 2020
@ljharb ljharb force-pushed the dotignore branch 3 times, most recently from 73a6532 to 3aa123c Compare January 8, 2020 06:24
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and made the changes. Thanks!

@ljharb ljharb force-pushed the dotignore branch 2 times, most recently from 7b52a88 to a0f9350 Compare January 8, 2020 07:11
@ljharb ljharb merged commit a0f9350 into tape-testing:master Jan 8, 2020
ljharb added a commit that referenced this pull request Jan 8, 2020
v4.13.0

  - [New] `tape` binary: Add -i flag to ignore files from gitignore (#492)
  - [New] add `t.match()` and `t.doesNotMatch()`, new in `node` `v13.6`
  - [Deps] update `resolve`
  - [Tests] handle stack trace variation in node <= 0.8
  - [lint] fix object key spacing
@r0mflip
Copy link
Contributor Author

r0mflip commented Jan 8, 2020

Sorry I didn't look at any of your comments and review. I am on the other side of the world as you. Timing issues 😝

@ghost
Copy link

ghost commented Aug 20, 2020

This is a really weird feature. tape assumes git now and reads gitignore files? I am very against this.

@ljharb
Copy link
Collaborator

ljharb commented Aug 20, 2020

@substack are you only against the default of .gitignore, or against the entire -i feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to ignore node_modules or files in .gitignore by default
2 participants