From af108cd1b4614130ca2f865ae8c484b0499832d8 Mon Sep 17 00:00:00 2001 From: Chandra Sanapala Date: Tue, 30 Jul 2024 04:18:51 +0530 Subject: [PATCH] address review comments --- ...decimal.yaml => functions_aggregate_decimal_output.yaml} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename extensions/{functions_aggregate_decimal.yaml => functions_aggregate_decimal_output.yaml} (82%) diff --git a/extensions/functions_aggregate_decimal.yaml b/extensions/functions_aggregate_decimal_output.yaml similarity index 82% rename from extensions/functions_aggregate_decimal.yaml rename to extensions/functions_aggregate_decimal_output.yaml index cdeb9443e..c8ed988b5 100644 --- a/extensions/functions_aggregate_decimal.yaml +++ b/extensions/functions_aggregate_decimal_output.yaml @@ -2,7 +2,7 @@ --- aggregate_functions: - name: "count" - description: Count a set of values + description: Count a set of values. Result is returned as a decimal instead of i64. impls: - args: - name: x @@ -15,7 +15,7 @@ aggregate_functions: intermediate: decimal<38,0> return: decimal<38,0> - name: "count_star" - description: "Count a set of records (not field referenced)" + description: "Count a set of records (not field referenced). Result is returned as a decimal instead of i64." impls: - options: overflow: @@ -30,7 +30,7 @@ aggregate_functions: HyperLogLog. This function provides an alternative to the COUNT (DISTINCT expression) function, which returns the exact number of rows that contain distinct values of an expression. APPROX_COUNT_DISTINCT processes large amounts of data significantly faster than COUNT, with negligible deviation from the exact - result. + result. Result is returned as a decimal instead of i64. impls: - args: - name: x