feat: allow agg functions to be used in windows #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on discussion in Slack, this PR loosens the spec to allow aggregate functions to be re-used as window functions. |
EpsilonPrime
approved these changes
Aug 11, 2023
|
@jacques-n @cpcloud @westonpace Can we close this one out? |
westonpace
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
I'm good with this. Let's give @jacques-n a day to respond and, if no response, I think it's probably safe to interpret this slack quote as approval:
My intention was that aggregate functions can be used as window functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.