New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove implicit casts in trig extension functions #620

Merged

richtia merged 1 commit into substrait-io:main from richtia:remove_trig_upcast

Apr 12, 2024

Member

richtia commented Apr 4, 2024

This PR removes some implicit casts that exist in the trig functions.

More discussion here:
#251

Most of the trig functions already follow this behavior. This should handle the remaining ones.


          fix: remove implicit casts in trig functions

93de1c0

richtia requested review from jacques-n, cpcloud, westonpace, EpsilonPrime and vbarua as code owners

April 4, 2024 16:33

EpsilonPrime approved these changes

View reviewed changes

westonpace approved these changes

View reviewed changes

Member

westonpace left a comment

I checked a few systems and they all seem to mirror this behavior. They pick one type to be their canonical input and the return type is the same.

richtia merged commit b883120 into substrait-io:main

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

westonpace westonpace approved these changes

EpsilonPrime EpsilonPrime approved these changes

jacques-n Awaiting requested review from jacques-n jacques-n is a code owner

cpcloud Awaiting requested review from cpcloud cpcloud is a code owner

vbarua Awaiting requested review from vbarua vbarua is a code owner

Labels

None yet