Migration to Substrate V3 #15
Conversation
|
Hey @riusricardo, any update on this one? I'm asking since @fcroiseaux has delivered the first milestone for the Open Grants Program and the work on the DID pallet comprises a part of the delivery. Let me know if I can help, I'd be happy to! |
|
Hey! @mmagician thanks for the heads up. I wasn't aware that it was part of a milestone. I'll take a look ASAP. |
|
Hi Ricardo,
Actually there is no urgency since I’ve copied the pallet code in my
repository.
Regards,
…--
Fabrice Croiseaux
Le 3 mai 2021 à 14:26:25, Ricardo Rius ***@***.***) a écrit:
Hey! @mmagician <https://github.com/mmagician> thanks for the heads up. I
wasn't aware that it was part of a milestone. I'll take a look ASAP.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF6TF7OOZDCXQ6KZHRTWE3TL2I7DANCNFSM4ZFEMXJQ>
.
|
|
Hello, just curious when there will be an approving review? My team is interested in building on this component. Thanks @fcroiseaux for the work. Heads up @Damfortx8 (you were asking about this one). |
|
Hey I am also interested in reusing this component. Thank you @fcroiseaux. Why is the review pending for so long? |
I don't know why the review is taking so long. I presume nobody is reviewing it. |
|
It seems some people are interested by the code. @mmagician, can you review so that the PR can be merged ? |
|
@fcroiseaux I'll happily do it if you give me a week or so |
|
That’s fine !
…--
Fabrice Croiseaux
Le 2 mars 2022 à 09:51:12, Marcin ***@***.***) a écrit:
@fcroiseaux <https://github.com/fcroiseaux> I'll happily do it if you give
me a week or so
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF6TF7LPHREE6DHHCZTES3U54TX7ANCNFSM4ZFEMXJQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@fcroiseaux @mmagician Looks ok to me for an update to Substrate v3.0.0, so LGTM. But be aware that this pallet will not work as-is with the latest node template. It will first need to be updated to the latest Substrate monthly release. |
|
@sacha-l @riusricardo Do we have any plan for future evolutions of this pallet ? |
|
AFAIK, Nothing has been planned so far. |
No description provided.