-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Array support #36
Comments
I have not any plans for adding support for Arrays (at least in the foreseeable future), so it would be great if you could implement it and feel free to ask any question if you need. |
Any movement on this? This might be useful to me in the near future, and I would be willing to implement. |
Hey, sorry but I got stuck on something pretty early on and I needed a solution fast so I just worked around it by converting the array into a comma delimited string. I might attempt it again because I know I'll need it for inserts eventually, but definitely not in the following two months. |
I have added a basic implementation of arrays, and it's available since v0.1.13. |
wow, that's awesome, thanks! |
Are there any plans for adding support for Arrays? I would be interested in implementing this myself (with some guidance) if not.
I tried to look if I could implement this using existing building blocks in the library, but I got stuck immediately in
types::Value
. The first idea was to make the enum recursive by addingArray(List<Value>)
to it. However this would allow mixing different types. We could make a new Array type likestruct Array (SqlType, List<Value>)
which wouldn't allow inserting different values, though that is still pretty inefficient. I think the most efficient way would be to makeValue
generic likeValue<T = ()>
and then we could add anArray(List<T>)
to the enum.I'm not sure what the best approach would be here. What do you think?
The text was updated successfully, but these errors were encountered: