Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parseEnvs for expanding env and shell subst #99

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

sunggun-yu
Copy link
Owner

  • do parseEnvs with shell echo to handle both /Users/sunggun and shell subst in consist way
  • use os.ExpandEnv to handle /Users/sunggun, and subst env vars of current profile

- do parseEnvs with shell echo to handle both /Users/sunggun and shell subst in consist way
- use os.ExpandEnv to handle /Users/sunggun,  and subst env vars of current profile
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c92017) 93.84% compared to head (44865b6) 94.15%.
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   93.84%   94.15%   +0.31%     
==========================================
  Files          17       18       +1     
  Lines         682      719      +37     
==========================================
+ Hits          640      677      +37     
  Misses         24       24              
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunggun-yu sunggun-yu merged commit 862ce36 into main Nov 21, 2023
@sunggun-yu sunggun-yu deleted the fix/parse-env-n-shell-substitution branch November 21, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant