feat: consider session expired with margin on getSession() without auto refresh #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Jan 21, 2025
hf
pushed a commit
that referenced
this pull request
Jan 23, 2025
🤖 I have created a release *beep* *boop* --- ## [2.68.0](v2.67.3...v2.68.0) (2025-01-21) ### Features * consider session expired with margin on getSession() without auto refresh ([#1027](#1027)) ([80f88e4](80f88e4)) ### Bug Fixes * remove `internal-types.ts` ([#1014](#1014)) ([28ead89](28ead89)) * update docs to add scrypt ([#1012](#1012)) ([1225239](1225239)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
autoRefreshTokenis off (or when a tab is in the background) butgetSession()is called -- such as in an active Realtime channel,getSession()might return a JWT which will expire while the message is travelling over the internet. There is one confirmed case of this happening.This PR adjusts this using the established
EXPIRY_MARGIN_MSconstant (which only applies on initial initialization of the client). The constant's value is brought in line with theautoRefreshTokenticks which run every 30 seconds and refreshing is attempted 3 ticks prior to the session expiring.This means that JWTs with an expiry value less than 90s will always refresh the session; which is acceptable.