fix: isBrowser() to include check on window
#982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmoro
changed the title
|
What environment is this throwing in? |
Sveltekit. There are other situations this is an issue (see supabase/supabase-js#786) and many of those cases people are finding workarounds but not a root-cause fix. |
There are several checks in GoTrueClient.ts that check window?.[prop] after checking isBrowser() which throws an error in node environments that have "document" defined but not "window". So this is the most minimal check to be sure they don't throw by ensuring "window" is defined.
|
Just keep React Native, and possible other similar things, in mind here. |
@j4w8n Yes. My changes here only add a requirement for |
hf
changed the title
isBrowser() to include check on window
hf
approved these changes
Dec 16, 2024
hf
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.67.2](v2.67.1...v2.67.2) (2024-12-16) ### Bug Fixes * `isBrowser()` to include check on `window` ([#982](#982)) ([645f224](645f224)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several checks in
GoTrueClient.tsthat checkwindow?.[prop]after checkingisBrowser()which throws an error in node environments that havedocumentdefined but notwindow.Fixes: