fix: possible panic if refresh token has a null session_id #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11592000983Details
💛 - Coveralls |
cstockton
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Looking at the refresh token code and associated calls I think we should take some more time to consider this change.
|
we don't need to do the same check here because it's using |
|
👍 |
cstockton
approved these changes
Oct 30, 2024
J0
pushed a commit
that referenced
this pull request
Nov 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.164.0](v2.163.2...v2.164.0) (2024-11-13) ### Features * return validation failed error if captcha request was not json ([#1815](#1815)) ([26d2e36](26d2e36)) ### Bug Fixes * add error codes to refresh token flow ([#1824](#1824)) ([4614dc5](4614dc5)) * add test coverage for rate limits with 0 permitted events ([#1834](#1834)) ([7c3cf26](7c3cf26)) * correct web authn aaguid column naming ([#1826](#1826)) ([0a589d0](0a589d0)) * default to files:read scope for Figma provider ([#1831](#1831)) ([9ce2857](9ce2857)) * improve error messaging for http hooks ([#1821](#1821)) ([fa020d0](fa020d0)) * make drop_uniqueness_constraint_on_phone idempotent ([#1817](#1817)) ([158e473](158e473)) * possible panic if refresh token has a null session_id ([#1822](#1822)) ([a7129df](a7129df)) * rate limits of 0 take precedence over MAILER_AUTO_CONFIRM ([#1837](#1837)) ([cb7894e](cb7894e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
auth.sessionstable being created, some refresh tokens can contain a nullsession_id. In those cases, attempting to use those refresh tokens to obtain a new session will result in a panic.session_idto prevent panics from happening.What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.